fix(hosts): make group startup-command field multi-line typeable#1100
Merged
Conversation
The group details panel rendered Startup Command as a single-line <Input>, so users couldn't type newlines into it — only the first line ever made it into the saved config, which then broke the multi-line sequencing behavior shipped in #1096 for any host inheriting the command from its group. Switch to a 3-row <Textarea> to match the per-host details panel, so a multi-line command typed on the group is preserved end to end. Refs #1083. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1083 / #1096. User-reported (@pyroch): the multi-line startup-command sequence shipped in #1096 doesn't work for hosts under a group folder — only the first line ever runs.
Cause
GroupDetailsPanel.tsxrendered the group's Startup Command field as a single-line<Input>(className="h-10"). HTML<input>can't hold newlines, so users literally can't type a multi-line command on the group — only the first line is stored, and that one line is what each host inherits.HostDetailsPanel.tsxalready uses a 3-row<Textarea>for the same field, which is why the per-host case works. Execution (scheduleStartupCommand/splitStartupCommandLines) and group inheritance (applyGroupDefaultsdirectly copiesstartupCommand) are fine.Fix
Replace the group panel's
<Input>with the same<Textarea rows={3} className="min-h-[80px] font-mono text-sm">as the per-host panel.Test plan
npm run lint— cleannpm test— 1223 pass, 0 failnpm run build— success🤖 Generated with Claude Code