src: refactor updatesection!(psh::PoincareShooting - #336
Merged
rveltz merged 7 commits intoJul 19, 2026
Conversation
|
It might be a good idea to store the full vector ( |
- Introduce POSavedSolutionAndState_PSH / BVPSavedSolutionAndState_PSH
structs to save full solution state (reduced coords + full space +
section normals/centers)
- Add save_solution for PeriodicOrbitFunctionalSh{<:PoincareShooting}
- Add update! for PoincareShooting that re-projects the solution
after section update and recomputes the predictor
- Add restore_problem! for PoincareShooting to restore section state
- Replace update!(prob, x) calls with restore_problem!(prob, x, pars)
in NormalForms.jl
- Fix test files to use saved_solution() to extract vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.