Fix: onError hook not triggered for network errors #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wrap fetch() call in try/catch to handle network-level errors
- Network errors (ECONNREFUSED, DNS failures, etc.) now call onError hook
- Network errors return { data: null, error } instead of throwing
- Respect throw: true option for network errors
- Support retry for network errors
- Re-throw abort errors to preserve existing behavior
- Refactor error handling into shared handleError function
- Add comprehensive tests for network error scenarios
Fixes better-auth#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75
Network errors (ECONNREFUSED, DNS failures, timeouts) now behave consistently with HTTP errors:
onErrorhook is called{ data: null, error: { status: 0, statusText: "Network Error", message, cause } }BetterFetchErroronly whenthrow: trueAbort errors are re-thrown to preserve existing behavior.