Repository navigation
Fix lifecycle teardown, config drift and unbounded atom creation - #20
Merged
Merged
Conversation
- stop/0 releases what start/2 set up, so restart in one VM works - register hornbeam_presence, _channel and _channel_registry for Python - keep and release presence monitor refs - dist requires existing atoms for module/function, caps node names - one config defaults map instead of three, drop four dead options - default port 8000 to 8642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork before the durable execution work.
Restarting hornbeam in one VM did not work, presence from Python did nothing at all, and two inputs reachable from Python were unbounded. Config had drifted across three default maps.
stop/0releases whatstart/2set updefaults/0is the single config source; four dead options removedTwo judgment calls worth a look: this deletes two unreferenced runner modules, and leaves the Python shims unpackaged, since their module names are the public API.