Detect statically linked musl using the crt-static target feature, not target_vendor=alpine - #64
Open
thomcc wants to merge 5 commits into
Open
Detect statically linked musl using the crt-static target feature, not target_vendor=alpine#64thomcc wants to merge 5 commits into
thomcc wants to merge 5 commits into
Conversation
…t target_vendor=alpine
MattCatz
reviewed
Feb 7, 2025
|
I am porting (and seems to be correct based off of https://rust-lang.github.io/rfcs/1721-crt-static.html) |
|
@benfred is there any chance of getting this merged in? |
Co-authored-by: Matthew Cather <14895427+MattCatz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone reported a bug in the rust-lang zulip about your crate. I happened to notice that you're detecting statically linked musl the wrong way (or, a way that doesn't handle all cases), which is the cause of their bug. This probably fixes the issue for them, so long as they also provide some rustflags when compiling (specifically
RUSTFLAGS=-Ctarget-feature=-crt-staticto turn off static CRT).That said, this is extremely a driveby, I haven't tested it beyond being confident that this doesn't break the existing use case, as the alpine target doesn't set crt-static.