Open
Conversation
and portable C++ feature checks
This compiles with clang++-21 on OSX and should build on Windows too.
Add more test for unique_resource
ClausKlein
requested review from
JeffGarland,
neatudarius,
robert-andrzejuk and
wusatosi
as code owners
This was referenced Jan 15, 2026
scope_exit does not need to be move-assignable!
add get_version() to CXX_MODULE to export some code;
ClausKlein
force-pushed
the
feature/add-windows-ci
branch
from
350bcd8 to
1a86a99
Compare
This is needed if only an interface library is build
ClausKlein
force-pushed
the
feature/add-windows-ci
branch
from
79cd72c to
f51bfa4
Compare
Prevent warning: placeholder variables are a C++2c extension
ClausKlein
force-pushed
the
feature/add-windows-ci
branch
from
26120f1 to
7af734d
Compare
ClausKlein
commented
Jan 18, 2026
|
|
||
| set(package_install_dir ${CMAKE_INSTALL_LIBDIR}/cmake/beman.scope) | ||
|
|
||
| # TBD: always? CK |
Contributor
Author
There was a problem hiding this comment.
@ednolan why not check BEMAN_SCOPE_INSTALL_CONFIG_FILE_PACKAGE here?
ClausKlein
commented
Jan 27, 2026
ClausKlein
commented
Jan 27, 2026
ClausKlein
commented
Jan 27, 2026
Comment on lines
+60
to
+72
|
|
||
| include(GenerateExportHeader) | ||
|
|
||
| generate_export_header( | ||
| beman.scope | ||
| BASE_NAME beman.scope | ||
| EXPORT_FILE_NAME beman/scope/modules_export.hpp | ||
| ) | ||
| else() | ||
| add_library(beman.scope INTERFACE) | ||
| endif() | ||
|
|
||
| if(CMAKE_CXX_SCAN_FOR_MODULES) |
Contributor
Author
There was a problem hiding this comment.
@JeffGarland For windows DLL we need an export header too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This offers a portable implementation version that compiles on all OS with all C++23 compilers
NOTE: This version compiles on OSX with apple-clang, llvm-clang, and g++-15 too!
I have been prepared export headers to test with DLL's on Windows too.
see https://discourse.cmake.org/t/linker-error-with-cxx-modules/15449