34821 Suppress Annual Report filing todos for mainframe entities - #4763
Open
JazzarKarim wants to merge 2 commits into
Open
34821 Suppress Annual Report filing todos for mainframe entities#4763JazzarKarim wants to merge 2 commits into
JazzarKarim wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#34821
Description of changes:
This was brought up in our latest demo. Legacy/mainframe entities have all usually old founding dates. Here's an example of a library from 1940:
The todos show 87 annual report filings. It was brought up, these entities won't have the ability to submit these annual report filings. So, we wanna suppress that and not show them. This PR fixes that:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).