Support relocatable rpmbuild by adding data attribute to the toolchain#1047
Merged
aiuto merged 2 commits intobazelbuild:mainfrom Mar 17, 2026
Merged
Support relocatable rpmbuild by adding data attribute to the toolchain#1047aiuto merged 2 commits intobazelbuild:mainfrom
aiuto merged 2 commits intobazelbuild:mainfrom
Conversation
Collaborator
|
Could you add an example of the use under examples/rpm. |
aiuto
approved these changes
Mar 17, 2026
Collaborator
aiuto
left a comment
There was a problem hiding this comment.
The code looks good. The example will make it useful to others.
rpmbuild ships with runtime configuration files (lib/rpm/) that must be present for it to successfully build RPMs. When running under remote execution, these files were not being staged because the toolchain had no way to declare them as dependencies. Add a `data` attribute to `rpmbuild_toolchain` so that runtime files can be specified alongside the rpmbuild binary. These files are propagated through `RpmbuildInfo` and included as inputs to the MakeRpm action in `pkg_rpm`.
Contributor
Author
|
Thanks @aiuto. Updated the existing prebuilt rpmbuild example to use the new attribute. |
aiuto
approved these changes
Mar 17, 2026
linty
Collaborator
|
buildifier complaining. I fixed the line. |
Contributor
Author
|
Thanks @aiuto! |
rdesgroppes
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
What does this PR do? bump rules_pkg to Mar 17 main, picking up: - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: a contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 20, 2026
### What does this PR do? Bump `rules_pkg` to current `main`. ### Motivation Pick up: - bazelbuild/rules_pkg#1021: a contribution of ours - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this feature Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 27, 2026
### What does this PR do? Bump `rules_pkg` to current `main`. ### Motivation Pick up: - bazelbuild/rules_pkg#1021: a contribution of ours - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this feature Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
StephenWakely
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Mar 27, 2026
### What does this PR do? Bump `rules_pkg` to current `main`. ### Motivation Pick up: - bazelbuild/rules_pkg#1021: a contribution of ours - bazelbuild/rules_pkg#1024: RPM build errors would go unnoticed without it - bazelbuild/rules_pkg#1035: affects reproducibiliy of builds - bazelbuild/rules_pkg#1044 - bazelbuild/rules_pkg#1046: another contribution of ours (@chouquette) - bazelbuild/rules_pkg#1047: we might need this feature Co-authored-by: regis.desgroppes <regis.desgroppes@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpmbuild ships with runtime configuration files (lib/rpm/) that must be present for it to successfully build RPMs. When running under remote execution, these files were not being staged because the toolchain had no way to declare them as dependencies.
Add a
dataattribute torpmbuild_toolchainso that runtime files can be specified alongside the rpmbuild binary. These files are propagated throughRpmbuildInfoand included as inputs to the MakeRpm action inpkg_rpm.Expanded
examples/rpm/prebuilt_rpmbuildto demonstrate usage of the API. The existing example uses mockedrpmbuild, and this adds mockedlib/rpm/runtime data files