Redirect back to account settings page when the user role is changed …#2227
Merged
jorgemanrubia merged 1 commit intobasecamp:mainfrom Jan 7, 2026
Merged
Redirect back to account settings page when the user role is changed …#2227jorgemanrubia merged 1 commit intobasecamp:mainfrom
jorgemanrubia merged 1 commit intobasecamp:mainfrom
Conversation
…or when the user is removed from an account.
jorgemanrubia
approved these changes
Jan 7, 2026
Member
jorgemanrubia
left a comment
jorgemanrubia
left a comment
There was a problem hiding this comment.
Thanks, good catch @scart88 👍
Contributor
Author
|
@jorgemanrubia, @dhh Thanks for open-sourcing this project and for creating the videos explaining how things are designed and why they are designed in this specific way. This project helped me improve my Rails skills and follow a similar patterns on my little projects :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…or when the user is removed from an account.
Currently, when the user role is changed, there is a 406 error status and I think the service worker is redirectly automatically to account_settings_path and all assets are loaded again.
After this change, there are no errors and there is no need to reload all assets
