Skip to content

feat: add feature flag that allows disabling screen that says task validation origin skipped#162

Merged
jackchuma merged 1 commit intomainfrom
jack/task-validation-origin-feature-flag
Feb 25, 2026
Merged

feat: add feature flag that allows disabling screen that says task validation origin skipped#162
jackchuma merged 1 commit intomainfrom
jack/task-validation-origin-feature-flag

Conversation

@jackchuma
Copy link
Collaborator

@jackchuma jackchuma commented Feb 25, 2026

We are not yet ready to show this in our next mainnet task and want to prevent signer confusion resulting from the following image:

Screenshot 2026-02-24 at 6 22 06 PM

I tested a task with this update and confirmed that screen is now bypassed

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 25, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for 0x00101010 @ 2026-02-25 00:05:08 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for 0x00101010 @ 2026-02-25 00:06:03 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for 0x00101010 @ 2026-02-25 00:06:38 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@cb-heimdall
Copy link
Collaborator

Review Error for 0x00101010 @ 2026-02-25 00:11:29 UTC
User failed mfa authentication, either user does not exist or public email is not set on your github profile. \ see go/mfa-help

@jackchuma jackchuma merged commit 69fa90b into main Feb 25, 2026
6 checks passed
@jackchuma jackchuma deleted the jack/task-validation-origin-feature-flag branch February 25, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants