fix: merge duplicate contract entries in convertOverridesToJSON#161
Merged
fix: merge duplicate contract entries in convertOverridesToJSON#161
Conversation
Collaborator
✅ Heimdall Review Status
|
meyer9
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Forge simulation produces multiple StateOverrideDecoded tuples for the same contract address, the previous code naively pushed one output entry per input tuple, yielding duplicate addresses in the stateOverride array. Replace the simple push loop with a two-phase aggregate-then-emit approach: phase 1 collects all storage slots into a Map keyed by lowercase address (last-wins on key collision), phase 2 emits one StateOverride entry per unique address in sorted order.