Skip to content

fix: delete trailing ASCII when accepting prediction#300

Merged
ensan-hcl merged 3 commits intomainfrom
fix/prediction-trailing-ascii-delete
Mar 7, 2026
Merged

fix: delete trailing ASCII when accepting prediction#300
ensan-hcl merged 3 commits intomainfrom
fix/prediction-trailing-ascii-delete

Conversation

@ensan-hcl
Copy link
Member

@ensan-hcl ensan-hcl commented Mar 7, 2026

Summary

  • keep the existing predictive match behavior that ignores a trailing ASCII letter
  • also delete that trailing ASCII letter when accepting the prediction candidate
  • add regression tests for the trailing-ASCII and non-trailing-ASCII cases

Context

With "Enable predictive typing in development" enabled, accepting a candidate after input like おはようございm produced おはようございmます because the trailing ASCII letter was ignored for matching but no longer deleted on accept after the recent deleteCount refactor.

Testing

  • swift test currently fails before reaching these tests due to an upstream dependency build error in AzooKeyKanaKanjiConverter (DictionaryBuilder.swift missing import OrderedCollections under Swift 6.2 member import visibility checks)

@ensan-hcl
Copy link
Member Author

GA failure looked consistent with the AzooKeyKanaKanjiConverter revision pinned in Core/Package.swift.

I updated it to e57b2c82cdecdeb8dc9058a8d04264e79bea1ab3, which should include the Swift 6.2 compatibility fix for the previous build break.

Verification on this branch:

  • swift test in Core/ now completes successfully

This is included in commit 3b2d420.

@ensan-hcl ensan-hcl self-assigned this Mar 7, 2026
@ensan-hcl ensan-hcl added the codex label Mar 7, 2026
@ensan-hcl ensan-hcl merged commit e753ee4 into main Mar 7, 2026
8 checks passed
@ensan-hcl ensan-hcl deleted the fix/prediction-trailing-ascii-delete branch March 7, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant