Skip to content

Conversation

@blinkysc
Copy link
Contributor

@blinkysc blinkysc commented Dec 5, 2025

[!] Please Read! This PR comes from AI with MCP

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Adds C++ CreatureScript npc_cos_entrance_gossip for Hearthsinger Forresten (30551) and Fras Siabi (30552) to trigger their existing creature_text conversations with Footman James and Gryan Stoutmantle at the Culling of Stratholme entrance.

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .go xyz 1565 600 100 595 to teleport to CoS entrance area
  2. Wait for Hearthsinger Forresten and Fras Siabi to start their conversations
  3. Verify Hearthsinger talks with Footman James about the illness (4-line exchange)
  4. Verify Fras Siabi talks with Gryan Stoutmantle (3-line exchange with nod)

Known Issues and TODO List:

  • None

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added DB related to the SQL database Script file-cpp Used to trigger the matrix build labels Dec 5, 2025
Comment on lines +1654 to +1658
_events.Reset();
if (me->GetEntry() == NPC_HEARTHSINGER_FORRESTEN)
_events.ScheduleEvent(EVENT_HEARTHSINGER_OPENING, 10s, 15s);
else if (me->GetEntry() == NPC_FRAS_SIABI)
_events.ScheduleEvent(EVENT_FRAS_OPENING, 35s, 40s);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this code outside the constructor

@Nyeriah
Copy link
Member

Nyeriah commented Dec 5, 2025

Normally for simple talk like this events are not needed, the talk function has a built in delay param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database file-cpp Used to trigger the matrix build Ready to be Reviewed Script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Instance/Culling of Stratholme): First pack of Stratholme Citizens/Residents do not gossip about "the situation".

2 participants