fix(DB): Reference loot table 4001

[blinkysc]

[!] Please Read! This PR comes from AI with MCP

Note: This fix modifies reference_loot_template entry 6010, which is shared by 27 Zangamarsh creatures:

SELECT ct.entry, ct.name
  FROM creature_template ct
  JOIN creature_loot_template clt ON ct.lootid = clt.Entry
  WHERE clt.Reference = 6010
  ORDER BY ct.entry;

• 4 Giants (from issue): Bog Lord, Fungal Giant, Starving Bog Lord, Starving Fungal Giant
• 7 Naga: Bloodscale Enchantress, Slavedriver, Overseer, Wavecaller, Rajis Fyashe, Rajah Haghazed, Ssslith
• 6 Ogres: Ango'rosh Ogre, Mauler, Souleater, Shadowmage, Captain Krosh, Overlord Gorefist, Mal'druk, Chieftain Mummaki
• 4 Lost Ones: Daggerfen Muckdweller, Assassin
• 6 Beasts/Elementals: Marsh Walker, Lagoon Walker, Ironspine Threshalisk, Ironspine Gazer, "Count" Ungula, Mragesh

All will have grey weapon drop rate reduced from ~3% to ~0.05% per item. Green/blue rates remain unchanged.

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Zangamarsh] Wrong loot tables resulting in mass grey drops #14606
• Closes [Zangamarsh] Wrong loot tables resulting in mass grey drops chromiecraft/chromiecraft#4791

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Following sql query should show effective %0.05

  SELECT
      clt.Entry as creature_entry,
      ct.name as creature_name,
      clt.Chance as chance1,
      rlt1.Chance as chance2,
      (SELECT COUNT(*) FROM reference_loot_template WHERE Entry = rlt1.Reference AND GroupId = 1) as items_in_group,
      (clt.Chance / 100.0) * (rlt1.Chance / 100.0) /
          (SELECT COUNT(*) FROM reference_loot_template WHERE Entry = rlt1.Reference AND GroupId = 1) * 100 as effective_per_item_pct
  FROM creature_loot_template clt
  JOIN creature_template ct ON ct.entry = clt.Entry
  JOIN reference_loot_template rlt1 ON rlt1.Entry = clt.Reference
  WHERE clt.Entry IN (18125, 18127, 19519, 19734)
  AND clt.Reference = 6010
  AND rlt1.Reference = 4001;

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[sudlud]

So your pr description says 0.05%, but the sql says 0.5%

[blinkysc]

So your pr description says 0.05%, but the sql says 0.5%

Nested loot table so it’s effective drop rate becomes 0.05%