[FIX]: make entity linking deterministic across runs - #529
Open
oussamahansal wants to merge 3 commits into
Open
Conversation
|
BYOKG-RAG Coverage Report: The coverage is at unknown% (target: unknown%). Download the HTML report here. |
|
BYOKG-RAG Coverage Report: The coverage is at 95.0% (target: 80%). Download the HTML report here. |
noel-improv
approved these changes
Sep 9, 2026
noel-improv
left a comment
Collaborator
There was a problem hiding this comment.
Nice on this, just one non-blocker
|
BYOKG-RAG Coverage Report: The coverage is at 95.0% (target: 80%). Download the HTML report here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Entity linking is nondeterministic. The same query on the same graph with the same
topkreturns different seed sets between runs — and sometimes a different number of seeds. On the demo KG, 5 identical runs produced 5 distinct seed sets.Changes
fuzzy_string.py—sorted(set(...))for a hash-independent vocab orderbyokg_query_engine.py—list(dict.fromkeys(...))for the seed union (order-preserving dedup) andsorted(explored_entities)for the path retriever input.Problem
Related issue (if any): #
Testing
pytest)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.