Repository navigation
chore: align v1 maintenance branch configuration - #990
Conversation
apackeer
left a comment
There was a problem hiding this comment.
Requesting changes because the default-branch transition currently leaves v1's release and PR-validation paths disconnected.
-
Restore the dispatchable v1 release workflows on the default branch.
.github/workflows/release-pr.yml:16relies onworkflow_dispatch, while.github/workflows/tag-on-merge.yml:68and:99dispatchrelease.ymlandcodebuild.yml. GitHub currently registers Release PR, Release, and CodeBuild asdeletedbecause those workflow paths are absent from defaultmain;workflow_dispatchonly triggers when the workflow file exists on the default branch. Please add compatible default-branch workflow definitions/shims or redesign the dispatch path so the documented v1 release flow is executable. -
Restore v1 pull-request validation from the default-branch context.
.github/workflows/pull-request-lint.yml:4-5retargetspull_request_targettov1, but the workflow is absent from defaultmainand is registered asdeleted. This PR itself received no Pull Request Validation run, so the title, contributor statement, label, release-lock, and do-not-merge checks would remain inactive for v1 PRs. Please host the workflow onmainwith the appropriatev1base filter, or use a mechanism that executes from the v1 branch. -
Keep the CodeBuild trend artifact producer and consumer on the same branch/name.
.github/workflows/codebuild.yml:461-465now publishesreport-v1, butscripts/aidlc-evaluator/packages/trend-reports/src/trend_reports/fetcher.py:210-239still queries branchmainand artifactreport-main. That drops the v1 pre-release baseline from trend reports. Please parameterize the target branch/artifact and update the associated fetcher tests. -
Finish the required stale-reference sweep for the removed/renamed surfaces. At minimum,
.kiro/steering/pr-conventions.md:5still points to the deleted local PR template,docs/DEVELOPERS_GUIDE.md:62still says scanners targetmainand run daily, anddocs/ADMINISTRATIVE_GUIDE.md:77still counts the removed documentation workflow.
The existing checks are green, but they do not exercise the missing Pull Request Validation or dispatch paths above.
apackeer
left a comment
There was a problem hiding this comment.
Re-review complete at d7f44960312a.
The follow-up commit resolves the CodeBuild trend artifact mismatch and the cited stale documentation references. Default-branch PR validation is handled by the companion main-branch transition PR. The absence of the v1 release workflows from default main is intentional and deferred to a separate PR, so it is not a blocker for this change.
All current checks pass. Approved.
Summary
v1.v1because the defaultmainbranch owns those repository-wide surfaces.main, direct new installations and upgrades there, and align the v1 administrative guide.Validation
actionlint1.7.12 on all remaining workflowsmarkdownlint-cli20.23.2 on all 59 Markdown filesscheduleorcronremains under.github/workflows/maingit diff --checkBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.