Skip to content

fix: replace account ID with placeholder in PingFederate sample's aws-targets.json#1535

Open
cls-aws wants to merge 2 commits into
awslabs:mainfrom
cls-aws:main
Open

fix: replace account ID with placeholder in PingFederate sample's aws-targets.json#1535
cls-aws wants to merge 2 commits into
awslabs:mainfrom
cls-aws:main

Conversation

@cls-aws

@cls-aws cls-aws commented May 20, 2026

Copy link
Copy Markdown
Contributor

Amazon Bedrock AgentCore Samples Pull Request

Concise description of the PR

Changes to PingFederate sample's aws-targets.json, to replace account ID with placeholder.

User experience

Before: aws-targets.json exposed account ID
After: Uses the placeholder 123456789012. The existing deploy script (deploy_sample.sh) overwrites this file at deploy time with the caller's actual account ID, so there is no functional impact.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • Add your name to CONTRIBUTORS.md
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [N/A] Are you uploading a dataset?
  • [N/A] Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • I agree to resolve any issues created for this example in the future.
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@github-actions github-actions Bot added 01-tutorials 01-tutorials 03-AgentCore-identity 01-tutorials/03-AgentCore-identity labels May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01-tutorials 01-tutorials 03-AgentCore-identity 01-tutorials/03-AgentCore-identity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant