Run the macOS jobs on a single OS version - #3513
Open
justsmth wants to merge 1 commit into
Open
Conversation
macOS is the smallest GitHub-hosted concurrency pool and the only one a dedicated larger-runner group cannot relieve, because its ceiling is shared between standard and larger runners. A single aws-lc PR push peaked at 13 simultaneous macOS jobs and 619 macOS minutes, so macOS is where our footprint is proportionally largest. macOS-ARM and macOS-ARM-FIPS each ran over macos-14 and macos-15. Both are arm64, and macOS-x86 already runs a single version (macos-15-intel), so the second version on the ARM side looks like drift rather than intent. Keep macos-15, the newer image. path-has-spaces ran a macos-14 cell for each ninja value. Path-with-spaces handling splits along POSIX versus Windows quoting, and macOS shares POSIX semantics with ubuntu-latest, which already covers both ninja values. This removes five macOS jobs: macOS-ARM (macos-14), macOS-ARM-FIPS (macos-14, 0), macOS-ARM-FIPS (macos-14, 22), and both path-has-spaces macos-14 cells. Together they measured about 265 of the 619 macOS minutes per push, a 43% reduction, and up to 5 of the 13 peak macOS slots. All remaining required checks are still produced: macOS-ARM (macos-15), macOS-ARM-FIPS (macos-15, 0), and the ubuntu-latest and windows-latest path-has-spaces cells. Requires removing four now-unproduced entries from the main ruleset's required status checks first: macOS-ARM (macos-14), macOS-ARM-FIPS (macos-14, 0), path-has-spaces (macos-14, 0) and path-has-spaces (macos-14, 1).
justsmth
force-pushed
the
macos-drop-redundant-llvm22-cell
branch
from
September 10, 2026 21:33
0c8b9a5 to
7390134
Compare
justsmth
changed the title
Contributor
|
🔒 Security Review — View Report Please review before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3513 +/- ##
==========================================
+ Coverage 78.36% 78.38% +0.02%
==========================================
Files 700 700
Lines 125684 125684
Branches 17377 17377
==========================================
+ Hits 98490 98517 +27
+ Misses 26322 26295 -27
Partials 872 872 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dougch
approved these changes
Sep 11, 2026
dougch
left a comment
dougch
left a comment
Contributor
There was a problem hiding this comment.
So needed, thanks for doing this.
Claude nit: the commit comment seems stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and motivation
macOS has the smallest concurrency ceiling of any GitHub-hosted runner pool, and it is the only one a dedicated larger-runner group cannot relieve, because that ceiling is shared between standard and larger runners. A single aws-lc PR push measured 619 macOS minutes and peaked at 13 simultaneous macOS jobs, so macOS is where our CI footprint is proportionally largest.
Description of changes
Drop
macos-14from three matrices, keepingmacos-15:macOS-ARMandmacOS-ARM-FIPSeach ran over both versions. Both are arm64, andmacOS-x86already runs a single version (macos-15-intel), so the second version on the ARM side looks like drift rather than intent.path-has-spacesran amacos-14cell for each ninja value. Path-with-spaces handling splits along POSIX versus Windows quoting, and macOS shares POSIX semantics withubuntu-latest, which already covers both values.Testing
Five macOS jobs are removed. Durations measured from a recent push:
macOS-ARM (macos-14)macOS-ARM-FIPS (macos-14, 22)macOS-ARM-FIPS (macos-14, 0)path-has-spaces (macos-14, 0)path-has-spaces (macos-14, 1)Coverage is unchanged in kind: arm64 under both Xcode clang and llvm@22 with FIPS, x86_64 via
macos-15-intel, and path-with-spaces on both POSIX and Windows. The three matrices were expanded and diffed against the required status check list to confirm every remaining required cell is still produced.Review considerations
macos-14entries have been removed from themainruleset's required status checks, so no required check is left unreported.macOS-ARM-FIPS (macos-14, 22)was never required.macos-15overmacos-14: newer image, and GitHub retires older macOS runners over time. The counter-argument is that the oldest supported OS catches accidental new-SDK dependencies. If that matters more, invert the choice.path-has-spacesassumes APFS case-insensitivity is out of scope for a path-quoting test. If it is in scope, that cell should stay.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.