Verify provider-wide algorithm reachability - #3486
Open
geedo0 wants to merge 1 commit into
Open
Conversation
geedo0
force-pushed
the
feat/reachability-test
branch
from
September 4, 2026 20:00
2b7c780 to
843ebb2
Compare
Keep one attributed reachability cell for every advertised algorithm across every operation class. Compare the cells with the provider's queried registry as duplicate-preserving sorted vectors so missing coverage, stale cells, and duplicate registrations fail visibly.
geedo0
force-pushed
the
feat/reachability-test
branch
from
September 4, 2026 20:12
843ebb2 to
70c0a6c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/sha2-all #3486 +/- ##
==============================================
Coverage 78.14% 78.15%
==============================================
Files 700 700
Lines 125595 125595
Branches 17373 17371 -2
==============================================
+ Hits 98146 98155 +9
+ Misses 26578 26569 -9
Partials 871 871 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
🔒 Security Review — View Report Please review before merging. |
justsmth
self-requested a review
September 8, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context and motivation
This test asserts that all algorithms advertised by the provider match against an inventory and that all algorithms in that inventory are available and served by AWS-LC. This provides breadth coverage for asserting that all algorithms we claim to support are in fact supported.
Description of changes
test/frontend/reachability_test.ccholds one cell per registry row, as an operation id and the row'sprimary name.
The inventory.
AdvertisedAlgorithmsMatchReachabilityCellsqueries the provider directly for everyoperation id from 1 to
OSSL_OP__HIGHEST, collects the primary name of each advertised row, and comparesthat against the cell table. The comparison is over duplicate-preserving sorted vectors rather than sets,
so an accidental second registration of the same name fails it as well as a missing cell.
The cells.
ReachabilityTest.IsReachableAndAttributedfetches each cell withprovider=awslcrequired and asserts the implementation it got back reports this provider, so a fallthrough to the
default provider cannot pass as reachability. An operation class with no attributed handler in the switch
fails the cell rather than skipping it, which is what makes the table's growth deliberate for future
operation types.
Testing
The test is the change. Control run: duplicating the SHA2-512/256 registry row fails the inventory. Under
a set comparison the same duplicate passes, which is why the vectors preserve duplicates.
Review considerations
failure rather than a silent gap.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache
2.0 license and the ISC license.