docs: use release_resources_async in PG async SQLAlchemy example - #1279
Open
AhmadMasry wants to merge 1 commit into
Open
AhmadMasry wants to merge 1 commit into
AhmadMasry wants to merge 1 commit into
Conversation
The async example called the sync release_resources(), which never runs the async shutdown hooks. The failover topology monitor and host_monitoring_v2 monitors started by this example register their teardown via register_shutdown_hook, so they were left running until asyncio.run() cancelled them at exit. Switch to `await release_resources_async()`, matching the shutdown ordering in SqlAlchemySupport.md and the MySQL async example.
AhmadMasry
force-pushed
the
fix/pg-async-example-release-resources
branch
from
October 1, 2026 07:04
c9bf6cf to
b0e8a43
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
docs/examples/PGSQLAlchemyAsyncFailover.pycalled the syncrelease_resources()at shutdown. That doesn't run the async shutdown hooks registered throughaws_advanced_python_wrapper.aio.cleanup.register_shutdown_hook. Both plugins in this example's URL register their teardown that way:failoverwithaurora-pg: the async cluster topology monitor (aio/host_list_provider.py)host_monitoring_v2: the async host monitors (aio/host_monitoring_plugin.py)As a result those monitor tasks kept running until
asyncio.run()cancelled them at exit.This PR switches the example to
await release_resources_async(). That function awaits the registered hooks and then calls the syncrelease_resources()itself. The change matches the shutdown order indocs/using-the-python-wrapper/SqlAlchemySupport.mdand in theaio/cleanup.pydocstring, and matches whatMySQLSQLAlchemyAsyncFailover.pyalready does.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.