feat: add Tortoise ORM support - #1054
Closed
faviansamatha wants to merge 30 commits into
Closed
Conversation
faviansamatha
force-pushed
the
feat/tortoise
branch
11 times, most recently
from
December 6, 2025 01:27
a7d1332 to
75164e6
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
3 times, most recently
from
December 18, 2025 01:36
61cf1df to
745b003
Compare
faviansamatha
commented
Dec 18, 2025
| is_cached_token = (token_info is not None and not token_info.is_expired()) | ||
| if not self._plugin_service.is_login_exception(error=e) or not is_cached_token: | ||
| raise AwsWrapperError(Messages.get_formatted("IamAuthPlugin.ConnectException", e)) from e | ||
| raise |
Contributor
Author
There was a problem hiding this comment.
We need to remove the wrapped error. If we get a failover and we get a network error, the failover plugin will not detect it.
faviansamatha
force-pushed
the
feat/tortoise
branch
4 times, most recently
from
December 18, 2025 08:50
5ccfcb6 to
1809d2e
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 18, 2025 08:54
1809d2e to
b98d0f9
Compare
faviansamatha
marked this pull request as ready for review
December 18, 2025 18:09
faviansamatha
force-pushed
the
feat/tortoise
branch
2 times, most recently
from
December 18, 2025 19:40
6818de4 to
3f57b87
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
3 times, most recently
from
December 18, 2025 21:45
ee7354d to
2f43547
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 18, 2025 22:15
2f43547 to
3ce3fcc
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 19, 2025 01:27
82c086e to
0b3b1c0
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 19, 2025 07:59
efb8dea to
fea8788
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 19, 2025 09:04
9eb71d8 to
0bedc08
Compare
faviansamatha
force-pushed
the
feat/tortoise
branch
from
December 19, 2025 09:55
60ba69c to
66d8b74
Compare
Contributor
Author
|
Closing this pull request as performance is not ideal. We need to revisit this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a backend mysql client using the Tortoise ORM support.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.