refactor: use the ServicesContainer PluginFactory method by default #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility requirements (#1565) Co-authored-by: Adnan Khan <[email protected]>
Co-authored-by: Karen <[email protected]>
… one PluginFactory interface
sergiyvamz
reviewed
Dec 10, 2025
aaron-congo
force-pushed
the
plugin-factories
branch
from
d9fd5e2 to
43e5645
Compare
sergiyvamz
approved these changes
Dec 11, 2025
Contributor
|
Can you update changelog.md accordingly. It'd nice to have a short "migration" guide for users that have custom plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the old PluginFactory method that accepts a PluginService argument
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.