Skip to content

agent/fileutil/artifact: convert dropped errors to log messages #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alrs wants to merge 1 commit into
base: mainline
Choose a base branch
from
+3 −3
Open

agent/fileutil/artifact: convert dropped errors to log messages #663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions agent/fileutil/artifact/artifact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,17 +400,17 @@ func Download(context context.T, input DownloadInput) (output DownloadOutput, er
var isLocalFile = false
isLocalFile, err = fileutil.LocalFileExist(input.SourceURL)
if err != nil {
err = fmt.Errorf("check for local file exists returned %v", err)
log.Infof("check for local file exists returned %v", err)
err = nil
}

if isLocalFile {
err = fmt.Errorf("source is a local file, skipping download. %v", input.SourceURL)
log.Infof("source is a local file, skipping download. %v", input.SourceURL)
output.LocalFilePath = input.SourceURL
output.IsUpdated = false
output.IsHashMatched, err = VerifyHash(log, input, output)
} else {
err = fmt.Errorf("source file wasn't found locally, will attempt as web download. %v", input.SourceURL)
log.Infof("source file wasn't found locally, will attempt as web download. %v", input.SourceURL)
// compute the local filename which is hash of url_filename
// Generating a hash_filename will also help against attackers
// from specifying a directory and filename to overwrite any ami/built-in files.
Expand Down