feat(summary_view): Make retention window configurable - #1531
Open
NithinChandranR-AWS wants to merge 1 commit into
Open
Conversation
Replace hardcoded INTERVAL '7' MONTH in summary_view WHERE clause with
${retention_months} substitution, defaulting to 7 for backward
compatibility. Users who retain more than 7 months of CUR data can now
set retention_months during deployment without forking the SQL.
Fixes aws-solutions-library-samples#1529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the hardcoded
INTERVAL '7' MONTHinsummary_view.sql(lines 92-93) with a${retention_months}substitution parameter that defaults to7.Customers who retain more than 7 months of CUR data (e.g. 36 months for annual analysis) can now configure the retention window during deployment without forking the SQL file.
Changes
cid/builtin/core/data/queries/cid/summary_view.sql: Replace hardcoded'7'with${retention_months}cid/builtin/core/data/resources.yaml: Addretention_monthsparameter with default'7'to the summary_view definitionBackward Compatibility
Default value is
7, preserving existing behavior for all current deployments. No action required from existing users.Fixes #1529