fix(cfn): Use ResourcePrefix parameter in cid-cfn.yml - #1517
Open
NithinChandranR-AWS wants to merge 1 commit into
Open
fix(cfn): Use ResourcePrefix parameter in cid-cfn.yml#1517NithinChandranR-AWS wants to merge 1 commit into
NithinChandranR-AWS wants to merge 1 commit into
Conversation
Replace hardcoded 'cid' prefix in S3 bucket ARNs and Glue database references with the ResourcePrefix parameter. This ensures cid-cfn.yml correctly references resources created by data-exports-aggregation.yaml when a non-default ResourcePrefix is used. Fixes aws-solutions-library-samples#1045
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #1045
Description
cid-cfn.ymlhardcodes thecidprefix in 4 resource ARN references (2 S3 bucket ARNs, 2 Glue database/table ARNs). When a customer deploysdata-exports-aggregation.yamlwith a non-defaultResourcePrefixvalue, the dashboard stack's IAM policy references the wrong bucket and Glue database.Changes
ResourcePrefixparameter tocid-cfn.yml(default:cid, matching the data-exports-aggregation template)${ResourcePrefix}-${AWS::AccountId}-data-exports!Join ['_', !Split ['-', !Sub '${ResourcePrefix}_data_export']]to match the naming convention indata-exports-aggregation.yamlBackward Compatibility
Default value is
cid— existing deployments are unaffected. Only customers who explicitly set a different ResourcePrefix in their data-exports stack need to pass the same value here.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.