Skip to content

Add LoadBalancer Ref support to VPCEndpointServiceConfiguration#322

Open
a-mcloughlin wants to merge 1 commit intoaws-controllers-k8s:mainfrom
a-mcloughlin:VPCEndpointServiceConfiguration-lb-refs
Open

Add LoadBalancer Ref support to VPCEndpointServiceConfiguration#322
a-mcloughlin wants to merge 1 commit intoaws-controllers-k8s:mainfrom
a-mcloughlin:VPCEndpointServiceConfiguration-lb-refs

Conversation

@a-mcloughlin
Copy link
Copy Markdown

@a-mcloughlin a-mcloughlin commented Apr 10, 2026

Issue #, if available: N/A

Description of changes:
Adding a GatewayLoadBalancerRef and NetworkLoadBalancerRef to the VpcEndpointServiceConfiguration crd,
referencing elbv2 LoadBalancer arn

Structure:

apiVersion: ec2.services.k8s.aws/v1alpha1
kind: VPCEndpointServiceConfiguration
metadata:
  name: test
spec:
  acceptanceRequired: false
  networkLoadBalancerRefs:
    - from:
        name: test

Tested locally, everything works as intended, and existing functionality is not impacted.

If a ref to a load balancer of the wrong type is passed to the ref fields (e.g. ALB), the aws api recognises the invalid LB type and logs the error cleanly

Thanks for taking the time to review!
I appreciate any feedback on this PR

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2026
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 10, 2026

Hi @a-mcloughlin. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot requested review from a-hilaly and knottnt April 10, 2026 21:55
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 10, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: a-mcloughlin
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant