Add LoadBalancer Ref support to VPCEndpointServiceConfiguration#322
Add LoadBalancer Ref support to VPCEndpointServiceConfiguration#322a-mcloughlin wants to merge 1 commit intoaws-controllers-k8s:mainfrom
Conversation
|
Hi @a-mcloughlin. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: a-mcloughlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Issue #, if available: N/A
Description of changes:
Adding a GatewayLoadBalancerRef and NetworkLoadBalancerRef to the VpcEndpointServiceConfiguration crd,
referencing elbv2 LoadBalancer arn
Structure:
Tested locally, everything works as intended, and existing functionality is not impacted.
If a ref to a load balancer of the wrong type is passed to the ref fields (e.g. ALB), the aws api recognises the invalid LB type and logs the error cleanly
Thanks for taking the time to review!
I appreciate any feedback on this PR
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.