Skip to content

feat: Add support for PrivateDnsPreference#321

Open
matrus2 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
matrus2:provate_dns_preference
Open

feat: Add support for PrivateDnsPreference#321
matrus2 wants to merge 1 commit intoaws-controllers-k8s:mainfrom
matrus2:provate_dns_preference

Conversation

@matrus2
Copy link
Copy Markdown

@matrus2 matrus2 commented Apr 7, 2026

Hi,

I would like to expose new schema for VPC Endpoint CRD:
API and CRD Schema Updates:

  • Added privateDNSPreference (string) and privateDNSSpecifiedDomains (array of strings) to the DNSOptions section in both the CRD and Helm chart schemas, enabling users to specify these options in their VPC Endpoint resources.

This is one of the functionality we miss currently.
Please provide any guidance in case I missed something.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 7, 2026
@ack-prow ack-prow bot requested a review from a-hilaly April 7, 2026 12:10
@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 7, 2026

Hi @matrus2. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow
Copy link
Copy Markdown

ack-prow bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matrus2
Once this PR has been reviewed and has the lgtm label, please assign knottnt for approval by writing /assign @knottnt in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from knottnt April 7, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant