Fix resource type completion for JSON#453
Open
Ben-Wormald wants to merge 2 commits intoaws-cloudformation:mainfrom
Open
Fix resource type completion for JSON#453Ben-Wormald wants to merge 2 commits intoaws-cloudformation:mainfrom
Ben-Wormald wants to merge 2 commits intoaws-cloudformation:mainfrom
Conversation
fix replacement range being set too high keep keys when completing values e.g. resource types simplify JSON formatting function for future improvements
Collaborator
|
Hello, thank you for the PR! We will review this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #450
Description of changes:
There is still some behaviour for JSON completions that isn't ideal but hopefully this is a first steo to improving it, cheers
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.