Make it possible to parse all printable utf chars#5
Open
mehmetumit wants to merge 1 commit intoawesome-gocui:masterfrom
Open
Make it possible to parse all printable utf chars#5mehmetumit wants to merge 1 commit intoawesome-gocui:masterfrom
mehmetumit wants to merge 1 commit intoawesome-gocui:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to make keybindings like
ö,ü,/work in dive . Because UTF characters may consist of more than one byte, I converted tokens to a rune array to accurately determine the size of each tokenFor example
öis 2 byte and string length is 2 but rune length is 1Also I changed
IsLettercheck toIsPrintto parse special characters.With this pull request, it will be possible to solve wagoodman/dive#129 and wagoodman/dive#415 issues.