Skip to content

stages: [commit-msg] removal - #16

Closed
richtja wants to merge 1 commit into
avocado-framework:mainfrom
richtja:pre-commit-message-fix
Closed

richtja wants to merge 1 commit into
avocado-framework:mainfrom
richtja:pre-commit-message-fix

Conversation

@richtja

@richtja richtja commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

This will remove commit-msg from stages configuration which will enable commitinit for every run of pre-commit check. This will fix the issues in CI when this check is not run, bacause it use to be run only in commit process.

This will remove commit-msg from stages configuration which will enable
commitinit for every run of pre-commit check. This will fix the issues
in CI when this check is not run, bacause it use to be run only in
commit process.

Signed-off-by: Jan Richter <jarichte@redhat.com>
@mr-avocado mr-avocado Bot moved this to Review Requested in Default project Mar 25, 2026
@richtja
richtja requested a review from harvey0100 March 25, 2026 16:51
@YvanY0

YvanY0 commented Mar 26, 2026

Copy link
Copy Markdown

Hello @richtja, commitlint can only run at commit-msg stage, during pre-commit stage, we haven't input the commit message, so run commitlint is meaningless. In CI, pre-commit run cannot get the commit context, and it will only run pre-commit hooks, and this is why I added a individual workflow file in VT for commitlint.https://github.com/avocado-framework/avocado-vt/blob/master/.github/workflows/commitlint.yml

@richtja

richtja commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

HI @PaulYuuu, I see. So that is what we have been missing in avocado. Thanks for help. I will close this one.

@richtja richtja closed this Mar 26, 2026
@github-project-automation github-project-automation Bot moved this from Review Requested to Done 114 in Default project Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 114

Development

Successfully merging this pull request may close these issues.

2 participants