fix: resolve low contrast input text in light mode(#290)(#291) - #292
Open
AkhileshPachnanda wants to merge 1 commit into
Open
fix: resolve low contrast input text in light mode(#290)(#291)#292AkhileshPachnanda wants to merge 1 commit into
AkhileshPachnanda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the rationale behind them. Reference any files, components, or modules modified.
Fixes #290 & #291
Description
This PR resolves a contrast issue in Light Mode where user-entered text in input fields (such as on the Sign Up and Sign In pages) was hardcoded to white (
text-white), resulting in low contrast (white text on a light gray background).Rationale & Changes:
Instead of modifying
text-whiteclasses on dozens of individual component inputs across the codebase, a clean, global CSS override was added tosrc/index.csstargeting allinput,textarea, andselectelements when Light Mode is active (html:not(.dark)). This safely forces entered text to use the theme-awarevar(--text-primary)color (black/dark gray) in Light Mode, while keeping it white in Dark Mode.Type of Change
Checklist
pnpm run testorvitest rununderbackend/) and they passVerification Details
1. Manual Verification
Steps to reproduce:
/signup) or Sign In (/signin) page.Expected result:
#0f172a), providing high contrast against the input field background.#f9fafb) as before.Visual Documentation