-
-
Notifications
You must be signed in to change notification settings - Fork 12.8k
add tecnickcom/gogen/sfcache #5942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdded a new cache library entry ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
725-725: Nit: standardize “singleflight” spelling.In Go parlance it’s commonly written “singleflight”. Consider this tiny tweak:
- - [sfcache](https://github.com/tecnickcom/gogen/tree/main/pkg/sfcache) - Simple, in-memory, thread-safe, fixed-size, single-flight cache for expensive lookups. + - [sfcache](https://github.com/tecnickcom/gogen/tree/main/pkg/sfcache) - Simple, in-memory, thread-safe, fixed-size, singleflight cache for expensive lookups.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
README.md
📄 CodeRabbit inference engine (AGENTS.md)
README.md: When modifying the Awesome list, keep categories with at least three entries
Descriptions in the Awesome list must end with a period
Avoid promotional copy; keep descriptions concise and neutral in the Awesome list
Do not remove existing list content unless removal is requested and justified
Files:
README.md
**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Keep documentation in English
Files:
README.md
{README.md,COVERAGE.md}
📄 CodeRabbit inference engine (AGENTS.md)
Align rendered documentation (README.md, COVERAGE.md, etc.) with behavior changes in main.go or helper packages
Files:
README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: quality
🔇 Additional comments (1)
README.md (1)
725-725: LGTM: entry fits guidelines.
- Neutral, concise, ends with a period.
- Correct alphabetical position under Caches.
- Subfolder link style matches other monorepo entries.
|
Automated Quality Checks (from CONTRIBUTING minimum standards)
These checks are a best-effort automation and do not replace human review. |
|
@avelino I would greatly appreciate your help in investigating this build failure. The 'PR Quality Checks' are failing, and the reported issues seem to be false positives. Given that the project adheres to semantic versioning and has functional code coverage, I am seeking clarification on whether this requires a fix from my side or indicates an error with the automated checks. Although I considered the possibility that awesome-go does not permit packages nested within larger library collections, a review of the README.md revealed precedents for similar entries. Any guidance you could offer would be highly valuable. Thank you for your time and help. |
We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.
Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.
Please provide some links to your package to ease the review
Pull Request content
Category quality
Note that new categories can be added only when there are 3 packages or more.
Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.
Please delete one of the following lines:
Thanks for your PR, you're awesome! 😎
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.