refactor: updated the key logic for storing MRRT token #1031
+194
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auth0/CredentialsManager.swift
Outdated
| private func getAPICredentialsStorageKey(audience: String, scope: String?) -> String { | ||
| // Use audience if scope is null else use a combination of audience and scope | ||
| if let scope = scope { | ||
| return "\(audience)::\(scope.replacingOccurrences(of: " ", with: "::"))" |
There was a problem hiding this comment.
Suggestion
if we have two scopes like this but the order is different ,
"user.read user.write"
"user.write user.read"
This would create duplicate keys for our cache . would recommend to do something like below
let normalisedScopes = scope
.split(separator: " ")
.sorted()
.joined(separator: "::")
NandanPrabhu
previously approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR updates the current key for storing token while using the MRRT flow. The current implementation maps token to each audience. This change considers scope also into the key logic as same audience can have different scope and can get different tokens issued for each scope. One example is the my-account use case.