You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
StereoIntensityShort doesnt seem to do anything #1
May be related, we found StereoIntensityLong was going out of bounds when is_pos > 7. The go implementation has a simple fix here hajimehoshi/go-mp3#24
The out of bounds issue was already fixed in OpenMP3. The issue is rather that the code only seems to round the input, due to some float -> int -> float conversion. Im sceptical this was the original intention of the code, and that the PDMP3 author made a mistake. If someone has an mp3 which uses this routine, then please send it to me.
Activity
BeamdogZach commentedon Mar 20, 2018
May be related, we found StereoIntensityLong was going out of bounds when is_pos > 7. The go implementation has a simple fix here hajimehoshi/go-mp3#24
audioboy77 commentedon Mar 28, 2018
The out of bounds issue was already fixed in OpenMP3. The issue is rather that the code only seems to round the input, due to some float -> int -> float conversion. Im sceptical this was the original intention of the code, and that the PDMP3 author made a mistake. If someone has an mp3 which uses this routine, then please send it to me.