audcore: don't include linux/stat.h - #1823
Merged
radioactiveman merged 1 commit intoJun 6, 2026
Merged
Conversation
on glibc, this is redundant (`sys/stat.h` includes `bits/statx.h` includes `linux/stat.h`). on musl, it results in an error that `struct statx` and `struct statx_timestamp` are being redefined. `sys/stat.h` is the proper interface to use when using `statx` on linux.
Member
|
Merged, thank you for the patch and for maintaining Audacious on Void Linux. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on glibc, this is redundant (
sys/stat.hincludesbits/statx.hincludeslinux/stat.h). on musl, it results in an error thatstruct statxandstruct statx_timestampare being redefined.sys/stat.his the proper interface to use when usingstatxon linux.tested this by building for
x86_64,i686,aarch64,armv7l, andarmv6lfor bothglibcandmuslon Void Linux.