feat(nestjs-gateway): migrate express gateway to apollo server#417
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97d411c51d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c1ba413 to
f5b142e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5b142e0fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 532d769ebb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1256c0f5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3506ef575a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Task
How to verify
Main scenario
Action: boot a real Nest HTTP gateway with a gRPC microservice, then execute GraphQL POST requests, GET / with Accept: text/html, and GET /.well-known/apollo/server-health
Expected result: gateway starts, gRPC query returns data, request metadata reaches gRPC, gRPC errors are exposed as INVALID_ARGUMENT exception data, the Apollo landing page returns HTML 200, and the Apollo health endpoint returns pass
Additional scenario
Action: run package lint, typecheck, focused unit tests, package build, and git whitespace check under the repo-managed Node runtime
Expected result: validation finishes without errors; existing peer warnings remain warnings
Architecture scenario
Action: inspect gateway handler, runtime, and HTTP boundaries
Expected result: handler selects the Nest HTTP adapter boundary, Express middleware lives only in the Express boundary, Fastify has an explicit boundary, and shared Mesh/Apollo/subscription/gRPC error formatting lives outside the HTTP boundary
Proofs