AXON-1648 - remember 'Push branch to remote' checkbox state on Start Work page #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-ocean-spirits
requested review from
Blastoplex,
amarg-at,
bhorai-atl,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
om-ukr,
sdzh-atlassian,
sspanchenko and
teg-atlassian
as code owners
bhorai-atl
force-pushed
the
AXON-1648-remember-last-push-new-branch-to-remote-checkbox-state
branch
from
420a028 to
95a6fdd
Compare
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
| const errorController = useContext(ErrorControllerContext); | ||
|
|
||
| const [pushBranchEnabled, setPushBranchEnabled] = useState(true); | ||
| const [pushBranchEnabled, setPushBranchEnabled] = useState(state.pushBranchPreference ?? true); |
Contributor
There was a problem hiding this comment.
🔎 Code Design - State Management
The initialization could cause UI flicker since state.pushBranchPreference is undefined on first render, showing the fallback value true briefly before the stored preference loads.
| await Container.context.globalState.update('startWorkWithRovoDev', enabled); | ||
| } | ||
|
|
||
| async getPushBranchPreference(): Promise<boolean> { |
Contributor
There was a problem hiding this comment.
🔎 Code Readability - Code Duplication
Consider extracting the storage key 'startWorkPushBranchToRemote' to a constant to avoid duplication and potential typos.
bhorai-atl
force-pushed
the
AXON-1648-remember-last-push-new-branch-to-remote-checkbox-state
branch
from
95a6fdd to
533cac5
Compare
bhorai-atl
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
Issue:
Start work page didn't remember last 'Push the new branch to remote' checkbox state and was always enabled by default.
After the changes, it remembers the last state of the checkbox
How Has This Been Tested?
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations: