fix: handle GitHub URLs with slash-based branches and multi-dot filenames#2203
Open
wdnmdtonyma wants to merge 2 commits into
Open
fix: handle GitHub URLs with slash-based branches and multi-dot filenames#2203wdnmdtonyma wants to merge 2 commits into
wdnmdtonyma wants to merge 2 commits into
Conversation
…ames Fixes asyncapi#1940 1. GitHub URL parsing: Changed from regex with `[^\/]+` for branch capture (which fails on branches like `feature/new-validation`) to capturing everything after `/blob/` and converting to raw.githubusercontent.com URL, which resolves branch/path ambiguity internally. 2. File extension detection: Changed `name.split('.')[1]` to `parts.pop()` to correctly extract the last extension segment. This fixes handling of multi-dot filenames like `my.asyncapi.yaml` (previously extracted `asyncapi` instead of `yaml`) and filenames without extensions.
wdnmdtonyma
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 0511ad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1940
This PR fixes two validation bugs in the CLI:
1. GitHub URL Parsing (slash-based branches)
Before: The regex
([^\/]+)for branch capture failed on branches with slashes (e.g.,feature/new-validation), causing 404 errors.After: Captures everything after
/blob/and converts toraw.githubusercontent.comURL, which resolves the branch/path ambiguity internally. This correctly handles:https://github.com/org/repo/blob/feature/new-validation/spec.yamlhttps://github.com/org/repo/blob/main/spec.yaml(still works)2. File Extension Detection (multi-dot filenames)
Before:
name.split('.')[1]extracted the wrong segment for multi-dot filenames:my.asyncapi.yaml→ extractedasyncapiinstead ofyamlasyncapi(no extension) → extractedundefinedAfter: Uses
parts.pop()to correctly extract the last extension:my.asyncapi.yaml→ extractsyaml✓asyncapi(no extension) → handled gracefully ✓Files Changed
src/domains/services/validation.service.ts— GitHub URL conversionsrc/domains/models/SpecificationFile.ts—fileExists()extension checksrc/apps/cli/commands/new/file.ts—createAsyncapiFile()extension checkHow to Test