Skip to content

fix: avoid invalid v3 optimized schema refs#2199

Open
darshan-Jahagirdar wants to merge 2 commits into
asyncapi:masterfrom
darshan-Jahagirdar:codex/fix-v3-optimize-invalid-refs
Open

fix: avoid invalid v3 optimized schema refs#2199
darshan-Jahagirdar wants to merge 2 commits into
asyncapi:masterfrom
darshan-Jahagirdar:codex/fix-v3-optimize-invalid-refs

Conversation

@darshan-Jahagirdar
Copy link
Copy Markdown

Fixes #1990.

This keeps asyncapi optimize --no-tty from producing invalid AsyncAPI 3.x documents when schema optimization rewrites nested/external schema refs into missing component refs. For AsyncAPI v3 documents, the CLI now adds the existing schema ignore mode automatically so non-schema optimizations can still run while preserving valid output.

Verification:

  • npm run build
  • npm run test:one -- test/integration/optimize.test.ts
  • npm run lint
  • git diff --check
  • Manual repro: optimized test/fixtures/dummyspec/optimize-v3-invalid-output.yml, scanned for invalid schema refs, then validated the generated file successfully.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

⚠️ No Changeset found

Latest commit: 03e1c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link
Copy Markdown

@darshan-Jahagirdar
Copy link
Copy Markdown
Author

Small follow-up on the changeset bot warning: a changeset is included now in 851f7b0 (.changeset/fix-v3-optimized-schema-refs.md). The warning above was posted against the earlier commit before that file was added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

[BUG] optimize creates invalid documents

1 participant