fix: handle GitHub URLs with slash-based branches and multi-dot filenames#2198
Open
nguyenquockhang1610 wants to merge 1 commit into
Open
Conversation
nguyenquockhang1610
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: f1b2a4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nguyenquockhang1610
force-pushed
the
fix/github-url-and-extension-parsing
branch
2 times, most recently
from
5668055 to
e0d11c0
Compare
…ames
Bug 1: GitHub URL parsing regex assumed branch names don't contain '/'.
URLs like github.com/org/repo/blob/feature/new-validation/spec.yaml
would incorrectly parse 'feature' as the branch and
'new-validation/spec.yaml' as the path.
Fix: Use a greedy match for everything after /blob/ and intelligently
split branch from path by finding the first segment containing a file
extension.
Bug 2: File extension detection used split('.')[1] which fails for
filenames with multiple dots (e.g., 'my.asyncapi.yaml' returns
'asyncapi' instead of 'yaml').
Fix: Use split('.').pop() to get the last extension segment.
Fixes asyncapi#1940
nguyenquockhang1610
force-pushed
the
fix/github-url-and-extension-parsing
branch
from
e0d11c0 to
f1b2a4d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two validation bugs causing valid inputs to fail (#1940).
Bug 1: GitHub URL Parsing
Before: Regex
([^\/]+)for branch only matches single path segment.After: Greedy match + intelligent split finds file boundary.
Bug 2: File Extension Detection
Before:
name.split(".")[1]returns wrong segment for multi-dot names.After:
name.split(".").pop()returns last segment.Files Changed
src/domains/services/validation.service.ts— GitHub URL parsingsrc/domains/models/SpecificationFile.ts— extension detectionsrc/apps/cli/commands/new/file.ts— extension detectionFixes #1940