Skip to content

Conversation

@sendittothenewts
Copy link

windows-sys is a frequent source of duplicate dependencies. Widening the range of allowed versions gives downstream crates a fighting chance of being able to select one unique version of it.

cargo test does pass all tests with both windows-sys 0.61 and 0.28 (and fails to compile on windows-sys 0.27).

windows-sys is a frequent source of duplicate dependencies.  Widening the range
of allowed versions gives downstream crates a fighting chance of being able to
select one unique version of it.
@epage
Copy link
Contributor

epage commented Sep 10, 2025

I'm fine updating windows-sys but there is a certain level of support and usability burden when using multi-major version ranges which I'm not willing to accept at this time

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17597698914

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.992%

Totals Coverage Status
Change from base Build 16807910327: 0.0%
Covered Lines: 1439
Relevant Lines: 2822

💛 - Coveralls

@sendittothenewts
Copy link
Author

Fair enough. Since some of snapbox's dependencies don't support 0.61 yet, bumping this now would actually create the duplicate dependency problem I was hoping to avoid. Also, windows-sys 0.61.0 has an MSRV of 1.71, higher than snapbox. So, I would suggest leaving this as it is for now.

@sendittothenewts
Copy link
Author

The ecosystem has moved on and snapbox's dependencies do now support windows-sys 0.61, so bumping it would now be useful. The MSRV issue on Windows remains though, and a multi-major dependency is still a possible solution to that, although I personally would also be fine with just merging #402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants