Fix nuget restore in prbenchmarks.yml and regressionbot.yml #2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the pipeline dotnet restore was accidentally not using the nuget.config in the repo since we ran dotnet from the checkout root. Instead we can set `workspaceRoot: true` on the crank checkout step to make it the default working directory. This fixes network isolation violations in the pipelines.
Contributor
Author
|
I ran an internal test build in https://dev.azure.com/dnceng/internal/_build/results?buildId=2853658&view=results |
LoopedBard3
approved these changes
Dec 4, 2025
Contributor
LoopedBard3
left a comment
LoopedBard3
left a comment
There was a problem hiding this comment.
Great catch! This looks good to me.
Contributor
Author
|
I don't have permissions to merge :) |
Member
|
@akoeplinger you can join this team if you want, also works for aspnet |
Contributor
Author
|
thanks. the OSS portal is down right now, will do once it's back up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pipeline dotnet restore was accidentally not using the nuget.config in the repo since we ran dotnet from the checkout root. Instead we can set
workspaceRoot: trueon the crank checkout step to make it the default working directory.This fixes network isolation violations in the pipelines.
/cc @LoopedBard3 @sebastienros