Skip to content

Rewrite async_timeout imports - #433

Closed
mxr wants to merge 1 commit into
asottile:mainfrom
mxr:async-timeout-rewrite
Closed

Rewrite async_timeout imports#433
mxr wants to merge 1 commit into
asottile:mainfrom
mxr:async-timeout-rewrite

Conversation

@mxr

@mxr mxr commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

async-timeout is deprecated because its functionality was upstreamed into Python 3.11+. This rewrite follows the migration pattern from the README: https://github.com/aio-libs/async-timeout/tree/7dc0022fb8160e3d7905cefa279e034e37063814#deprecated

Comment thread tests/reorder_python_imports_test.py Outdated
@mxr
mxr force-pushed the async-timeout-rewrite branch from e922f6f to 9a3027b Compare April 5, 2026 23:14
@mxr
mxr requested a review from asottile April 5, 2026 23:14
@mxr

mxr commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

expired is a dual property/function in async_timeout but a function only in async.timeout. So the latter will always be truthy

@mxr mxr closed this Apr 7, 2026
@mxr
mxr deleted the async-timeout-rewrite branch April 7, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants