Skip to content

There are multiple templates named 'leaderboard' #482

Open

Description

@tab00

After updating to 0.8.43 I saw the above error in the console, and the app doesn't load.

I downgraded to 0.8.42 and my app is working again.

Please fix this problem so that we can use the latest version.

Thank you.

Activity

  1. aslagle commented on Nov 20, 2017

    @aslagle
    Owner

    Sorry about that. The only thing I changed in 0.8.43 was the dependency on underscore to fix #481, and I don't see how that would cause this problem. It's commit c81598a.

    Maybe meteor publish did something weird. In that case it wouldn't help to revert the change and publish again. Any ideas?

  2. harrisonhunter commented on Nov 20, 2017

    @harrisonhunter

    I also saw this behavior and was unable to build render my application correctly because of issues with the leaderboard template:
    https://www.dropbox.com/s/q59392gj6zzv6cf/Screenshot%202017-11-19%2023.04.18.png?dl=0
    reverting made it work normally

  3. aslagle commented on Nov 20, 2017

    @aslagle
    Owner

    Weird. The leaderboard template is used in examples but they're not supposed to be part of the package. I published with a newer version of meteor than I've used in the past so maybe it included those files even though they're not listed in package.js. I haven't been keeping up with the changes to meteor.

  4. rmuratov commented on Nov 20, 2017

    @rmuratov

    Can confirm, same issue with multiple templates with one name. Switched back to 0.8.42, everything works fine. Maybe changes in build process.

    EDIT Having no other ideas I tried replacing old api.add_files with api.addFiles etc (as suggested in docs). Without any success. For now I ended up with removing the whole examples dir.

    @s7dhansh thought the same about eager loading, but what's the point of adding files explicitly then...

  5. s7dhansh commented on Nov 20, 2017

    @s7dhansh
    Contributor

    I think the leaderboard template is being compiled multiple times as it is not in imports directory. The new meteor version for packages would have become more in sync with the normal apps, by eagerly loading everything in non-imports.

  6. aslagle commented on Nov 20, 2017

    @aslagle
    Owner

    I published 0.8.44 with an older version of meteor to see if it fixes the problem. I didn't make any other changes. Let me know if it works.

  7. added a commit that references this issue on Nov 20, 2017
  8. s7dhansh commented on Nov 20, 2017

    @s7dhansh
    Contributor

    Yes it does. The meteor shell issue is also fixed.

  9. rmuratov commented on Nov 20, 2017

    @rmuratov

    Yes, that worked for me as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions