Fix worker context leak in CSV exports - #2397
Open
anvit wants to merge 2 commits into
Open
Conversation
CSV export jobs were creating a new qubit/prod Symfony context inside the long-running worker. That leaked prod into later jobs and made arUpdateEsIoDocumentsJob enqueue descendant updates asynchronously instead of handling them inline. Keep the worker context intact and scope only the export culture changes needed for translated CSV output.
anvit
added
the
Type: bug
Add a unit test for the withUserCulture method for arExportJob
Contributor
Author
I just added a couple of test cases |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSV export jobs were creating a new qubit/prod Symfony context inside the long-running worker.
That leaked prod into later jobs and made arUpdateEsIoDocumentsJob enqueue descendant updates asynchronously instead of handling them inline.
Keep the worker context intact and scope only the export culture changes needed for translated CSV output.