fix: update Dockerfiles and Fix Vulnerable Dependencies#67
Merged
Conversation
- Upgrade Node.js 25.4 → 26.1, PHP 8.5.3 → 8.5.6, Rust 1.93 → 1.95.0 - Update vulnerable Java deps: commons-compress 1.25.0 → 1.27.1, pdfbox 3.0.1 → 3.0.4 - Bump cryptography ≥44.0.1 (addresses CVE-2024-12797) - Add SHELL directive and apt cleanup to rust.Dockerfile (security hardening) - Add PLATFORM variable to build-images.sh for flexible local builds - Improve .dockerignore: remove duplicates and add missing exclusions - Fix validate-multiarch-builds.sh: correct nonexistent shell.Dockerfile references to the actual changed Dockerfiles (nodejs, php, rust); amd64-only builds
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds tooling and updates Docker assets to improve/standardize multi-arch validation and modernize build dependencies.
Changes:
- Added a branch-specific multi-arch build validation script using
docker buildx build. - Parameterized
scripts/build-images.shto build with a configurable target platform (defaultlinux/amd64). - Updated several Docker images/dependency pins and expanded
.dockerignorepatterns to reduce build context noise.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/validate-multiarch-builds.sh | New script to validate builds for selected branches across architectures via buildx. |
| scripts/build-images.sh | Introduces a PLATFORM variable and uses it for docker build invocations. |
| docker/rust.Dockerfile | Bumps Rust image tag and improves apt cleanup in final stage. |
| docker/requirements/python-utilities.txt | Minor bump for cryptography minimum version. |
| docker/requirements/java-deps.txt | Updates a few Maven artifact URLs and checksums. |
| docker/php.Dockerfile | Updates pinned PHP version arg. |
| docker/nodejs.Dockerfile | Updates Node base image tags across stages. |
| .dockerignore | Adds many ignores (caches, venvs, node_modules, etc.) to shrink Docker build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3
to
+4
| # Uses the multiarch-builder (BuildKit) — no push, no local load. | ||
| # Cleans up any locally loaded test images after validation. |
Comment on lines
+53
to
+60
| # ── feat-shell-languages ──────────────────────────────────────────────────── | ||
| if [[ "$TARGET_BRANCH" == "feat-shell-languages" ]]; then | ||
| info "Checking out $TARGET_BRANCH …" | ||
| git -C "$REPO_ROOT" checkout "$TARGET_BRANCH" | ||
|
|
||
| build_test "shell.Dockerfile" "linux/amd64" "shell" | ||
| build_test "shell.Dockerfile" "linux/arm64" "shell" | ||
| fi |
Comment on lines
+84
to
+86
| if [[ ${#FAILED[@]} -eq 0 ]]; then | ||
| echo -e "${GREEN}All builds passed.${NC}" | ||
| else |
Comment on lines
+81
to
85
| # Documentation (optional—comment out if needed in build context) | ||
| # docs/ | ||
| # *.md | ||
| # README* | ||
|
|
aron-muon
changed the title
|
🎉 This PR is included in version 3.5.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Docker base image tags to latest stable versions, patches known security vulnerabilities in Java and Python dependency specifications, and refactors the build script for improved platform configurability.
Changes
Image Tag Upgrades
25.4-debian1326.1-debian138.5.3-debian-13-dev8.5.6-debian-13-dev1.93-debian13-dev1.95.0-debian13-devSecurity Fixes — Java Dependencies
Security Fixes — Python Dependencies
Build Script Improvements
PLATFORMas a configurable variable (was hardcodedlinux/amd64)--platformCLI option for easy multi-arch buildsscripts/validate-multiarch-builds.shfor CI validation.dockerignorefor cleaner build contextsFiles Modified
docker/nodejs.Dockerfiledocker/php.Dockerfiledocker/rust.Dockerfiledocker/requirements/java-deps.txtdocker/requirements/python-utilities.txtscripts/build-images.shscripts/validate-multiarch-builds.sh.dockerignore