fix: restore green Rust quality baseline (fmt, clippy, rustdoc, backend tests, lit) - #461
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arniber21
marked this pull request as ready for review
August 5, 2026 00:10
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arniber21
force-pushed
the
fix/rust-quality-baseline
branch
from
August 5, 2026 00:11
878ac49 to
3d659c2
Compare
arniber21
force-pushed
the
fix/rust-quality-baseline
branch
from
August 5, 2026 00:16
3d659c2 to
e48fbb4
Compare
arniber21
force-pushed
the
fix/rust-quality-baseline
branch
from
August 5, 2026 00:32
e48fbb4 to
922814e
Compare
…nd tests, lit) Restores the four quality gates that regressed after the #389–#415 fix batch (#455–#460) landed without a green `just test-ci`: - **fmt**: `cargo fmt --all` on ~30 drifted files - **clippy**: fix `needless_borrow` in `quon_core/depth.rs`, `manual_div_ceil` in `mlir_bridge/phase_polynomial.rs`, `needless_question_mark` in `frontend/lower.rs` (x2), `needless_borrows_for_generic_args` in `quon_na/tests`, remove dead `is_captured` in `mlir_bridge/ffi.rs` - **rustdoc**: remove intra-doc links to private items in `mlir_bridge/ffi.rs` (`PassContext`, `with_context`) and `mlir_bridge/diagnostics.rs` (`crate::ffi::emit_error`) - **backend tests**: `all_to_all_1000_qubits_constructs_quickly` accessed the now-private `dist` field (sealed by #394); switched to the public `num_qubits()`/`dist()` accessors - **lit**: register missing `%clifford-t-opt` substitution in `test/lit/lit.cfg.py` — the two Clifford+T lit tests referenced it but the config never defined it All gates verified green: cargo fmt --all -- --check ✅ cargo clippy --workspace --exclude flux_verify --all-targets -- -D warnings ✅ RUSTDOCFLAGS='-D warnings' cargo doc --workspace --exclude flux_verify --no-deps ✅ cargo nextest run --workspace --exclude flux_verify → 5106 passed, 0 failed npx @taskless/cli@latest check → No issues found Also adds the re-review report at `docs/reviews/idiomatic-rust-re-review-2026-08-04.md`.
arniber21
force-pushed
the
fix/rust-quality-baseline
branch
from
August 5, 2026 00:59
922814e to
6a94d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the four quality gates that regressed after the #389–#415 fix
batch (#455–#460) landed without a green
just test-ci:cargo fmt --allon ~30 drifted filesneedless_borrowinquon_core/depth.rs,manual_div_ceilinmlir_bridge/phase_polynomial.rs,needless_question_markinfrontend/lower.rs(x2),needless_borrows_for_generic_argsinquon_na/tests,remove dead
is_capturedinmlir_bridge/ffi.rsmlir_bridge/ffi.rs(PassContext,with_context) andmlir_bridge/diagnostics.rs(crate::ffi::emit_error)all_to_all_1000_qubits_constructs_quicklyaccessed the now-private
distfield (sealed by Seal backend target and connectivity invariants #394); switched tothe public
num_qubits()/dist()accessors%clifford-t-optsubstitution intest/lit/lit.cfg.py— the two Clifford+T lit tests referenced itbut the config never defined it
All gates verified green:
cargo fmt --all -- --check ✅
cargo clippy --workspace --exclude flux_verify --all-targets -- -D warnings ✅
RUSTDOCFLAGS='-D warnings' cargo doc --workspace --exclude flux_verify --no-deps ✅
cargo nextest run --workspace --exclude flux_verify → 5106 passed, 0 failed
npx @taskless/cli@latest check → No issues found
Also adds the re-review report at
docs/reviews/idiomatic-rust-re-review-2026-08-04.md.