Add license scan report and status#4909
Conversation
Signed off by: fossabot <badges@fossa.com>
Greptile SummaryThis PR integrates FOSSA license scanning into the repository by adding FOSSA status badges to
Confidence Score: 4/5Safe to merge — the only changes are documentation badges with no impact on build or runtime behaviour. The change is limited to README formatting: a badge is added with inconsistent indentation and a misplaced alt attribute, and the file lacks a trailing newline. None of these affect functionality. README.md has minor formatting inconsistencies worth tidying before merge. Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer / CI
participant FOSSA as FOSSA Service
participant GitHub as GitHub README
Dev->>FOSSA: Push code (FOSSA scans dependencies)
FOSSA-->>Dev: Scan complete, badge URLs available
Dev->>GitHub: PR adds FOSSA badge URLs to README
GitHub->>FOSSA: Badge image request (shield / large)
FOSSA-->>GitHub: Returns live license scan status SVG
Reviews (1): Last reviewed commit: "Add license scan report and status" | Re-trigger Greptile |
| <p> | ||
| <a href="https://circleci.com/gh/armadaproject/armada"><img src="https://circleci.com/gh/helm/helm.svg?style=shield" alt="CircleCI"></a> | ||
| <a href="https://goreportcard.com/report/github.com/armadaproject/armada"><img src="https://goreportcard.com/badge/github.com/armadaproject/armada" alt="Go Report Card"></a> | ||
| <a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a> |
There was a problem hiding this comment.
The new FOSSA badge is missing the two-space indentation that all other badges in this block use, and the
alt attribute is placed on the <a> tag instead of the <img> tag (the <img> has no alt text). The other badges follow the pattern of putting alt on the <img> element.
| <a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a> | |
| <a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield" alt="FOSSA Status"/></a> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
|
||
|
|
||
| ## License | ||
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large) No newline at end of file |
There was a problem hiding this comment.
The file is missing a trailing newline. Most editors and linters expect text files to end with a newline character, and many CI checks (e.g.,
git diff heuristics) will flag this.
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large) | |
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large) |
Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.
Below are docs for integrating FOSSA license checks into your CI: