Skip to content

Add license scan report and status#4909

Open
fossabot wants to merge 1 commit into
armadaproject:masterfrom
fossabot:add-license-scan-badge
Open

Add license scan report and status#4909
fossabot wants to merge 1 commit into
armadaproject:masterfrom
fossabot:add-license-scan-badge

Conversation

@fossabot
Copy link
Copy Markdown

Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.

Below are docs for integrating FOSSA license checks into your CI:

Signed off by: fossabot <badges@fossa.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 13, 2026

Greptile Summary

This PR integrates FOSSA license scanning into the repository by adding FOSSA status badges to README.md — a shield badge in the header alongside other CI badges, and a full license report badge in a new ## License section at the bottom.

  • A FOSSA shield badge is inserted in the header badges block, but its indentation differs from the surrounding badges and the alt attribute is placed on the <a> element instead of the <img> element.
  • A new ## License section is added at the end of the file, though the file is missing a trailing newline after the badge.

Confidence Score: 4/5

Safe to merge — the only changes are documentation badges with no impact on build or runtime behaviour.

The change is limited to README formatting: a badge is added with inconsistent indentation and a misplaced alt attribute, and the file lacks a trailing newline. None of these affect functionality.

README.md has minor formatting inconsistencies worth tidying before merge.

Important Files Changed

Filename Overview
README.md Adds FOSSA license scan badge to the header badges block and a new License section at the end with a large license report badge; minor formatting inconsistencies (indentation, misplaced alt attribute, missing trailing newline).

Sequence Diagram

sequenceDiagram
    participant Dev as Developer / CI
    participant FOSSA as FOSSA Service
    participant GitHub as GitHub README

    Dev->>FOSSA: Push code (FOSSA scans dependencies)
    FOSSA-->>Dev: Scan complete, badge URLs available
    Dev->>GitHub: PR adds FOSSA badge URLs to README
    GitHub->>FOSSA: Badge image request (shield / large)
    FOSSA-->>GitHub: Returns live license scan status SVG
Loading

Reviews (1): Last reviewed commit: "Add license scan report and status" | Re-trigger Greptile

Comment thread README.md
<p>
<a href="https://circleci.com/gh/armadaproject/armada"><img src="https://circleci.com/gh/helm/helm.svg?style=shield" alt="CircleCI"></a>
<a href="https://goreportcard.com/report/github.com/armadaproject/armada"><img src="https://goreportcard.com/badge/github.com/armadaproject/armada" alt="Go Report Card"></a>
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The new FOSSA badge is missing the two-space indentation that all other badges in this block use, and the alt attribute is placed on the <a> tag instead of the <img> tag (the <img> has no alt text). The other badges follow the pattern of putting alt on the <img> element.

Suggested change
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield" alt="FOSSA Status"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield"/></a>
<a href="https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_shield"><img src="https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=shield" alt="FOSSA Status"/></a>

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread README.md


## License
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large) No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 The file is missing a trailing newline. Most editors and linters expect text files to end with a newline character, and many CI checks (e.g., git diff heuristics) will flag this.

Suggested change
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large)
[![FOSSA Status](https://app.fossa.com/api/projects/git%2Bgithub.com%2Farmadaproject%2Farmada.svg?type=large)](https://app.fossa.com/projects/git%2Bgithub.com%2Farmadaproject%2Farmada?ref=badge_large)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant