ci: check the links of the book and of the API docs#2
ci: check the links of the book and of the API docs#2anlavandier wants to merge 6 commits intomainfrom
Conversation
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Summary 0.2.1Book
Api docs
|
Summary 0.2.0Book
Api docs
|
Summary 0.1.0Book
Api docs
|
Signed-off-by: Antoine Lavandier <antoine.lavandier@inria.fr>
Summary 0.3.0Book
Api docs
|
|
@ROMemories, I was looking at the link to |
|
Looking at the API docs of 0.1.0, clearly
|
|
It's not exactly clear to me yet what this is attempting to do: it would only comment on PRs on this repo with the overall status of links, and not block the PR (unlike what we do in ariel-os/ariel-os, right? I usually find that kind of monitoring very useful, but wouldn't it be too late anyway when we PR the docs to this repo? |
|
The primary reason was for me to have a way to:
It's not blocking because some link are never going to work because it's upstream's fault. For example there are link to licenses down the page in the embedded_hal part of our doc which lead to a 404. The same links are present on the docs.rs page as well and also 404. As for why it's in this repo and not the main, first for testing here to figure out if we want to go further with this and also to help when "backporting" some fixes to our older docs |
ROMemories
left a comment
There was a problem hiding this comment.
I'm a bit wary of adding CI to this repo, at least because we don't have a bot set up that would update the pinned Actions. I think it's fine if we keep it just an open PR for a bit? This should likely partially migrate to the main repo anyway.
| lychee: | ||
| strategy: | ||
| matrix: | ||
| tags: ["0.1.0", "0.2.0", "0.2.1", "0.3.0"] |
There was a problem hiding this comment.
| tags: ["0.1.0", "0.2.0", "0.2.1", "0.3.0"] | |
| tags: ["0.1.0", "0.2.0", "0.2.1", "0.3.0", "0.4.0"] |
|
Yes, I think that it's better to just rework the CI part of this PR for the current docs through ariel-os/ariel-os/pull/1894. The changes of the linked PR can be retroactively applied to the existing docs |
No description provided.