This repository was archived by the owner on Dec 17, 2025. It is now read-only.
feat: add health check support for ArgoCD Application #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jasonz <[email protected]>
ksdpmx
force-pushed
the
feature/argo-app-health
branch
from
9caaa06 to
2ab4281
Compare
|
Member
|
Closing since this should be implemented as a Lua script on the argo-cd repo. But I'm supportive of the change! We'll just need to be very very careful to get the check logic in good shape and communicate via release notes that people will need to disable it if they don't want the check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a centralized ArgoCD instance in the control plane, it may sometimes be necessary to configure an ArgoCD Application as a hook, e.g. running an application as a post-sync hook, and specifying a destination cluster to execute jobs in a data plane cluster.
But right now the health check for this CRD is not supported in ArgoCD (or Helm either).. which makes it hard for the controller to determine whether to clean up the hook or not when using the delete policy HookSucceeded.